Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow triggering :post_convert events atomically #8465

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

ashmaroli
Copy link
Member

  • This is a 馃悰 bug fix.
  • I've added tests.

Summary

Jekyll::Document instances allows triggering all registered hook events for owner :documents as well as an individual collection:

def trigger_hooks(hook_name, *args)
Jekyll::Hooks.trigger collection.label.to_sym, hook_name, self, *args if collection
Jekyll::Hooks.trigger :documents, hook_name, self, *args
end

But this support was not extended for the post_convert hook event on master (hook event to be introduced in v4.2).

This pull request fixes the above discrepancy.

@ashmaroli ashmaroli added the fix label Nov 11, 2020
@ashmaroli ashmaroli added this to the 4.2 milestone Nov 11, 2020
@DirtyF
Copy link
Member

DirtyF commented Nov 11, 2020

@jekyllbot: merge +fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants