Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate items from site.include list only once #8463

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Generate items from site.include list only once #8463

merged 1 commit into from
Nov 9, 2020

Conversation

ashmaroli
Copy link
Member

  • This is a 馃悰 bug fix.
  • I've added tests.

Summary

Before reading explicitly included files, Jekyll should check if the file has been read-in already.

Context

Resolves #8461

DirtyF
DirtyF approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ashmaroli
Copy link
Member Author

You're welcome :)
@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit db9ca22 into jekyll:master Nov 9, 2020
jekyllbot added a commit that referenced this pull request Nov 9, 2020
@jekyllbot
Update history to reflect merge of #8463 [ci skip]
11ff8aa
@ashmaroli ashmaroli deleted the conditionally-initialize-included branch November 9, 2020 12:04
This was referenced Mar 12, 2021
Closed
Merged
Merged
Merged
Merged
@jekyll jekyll locked and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict detects twice instance of the same static file
3 participants
@ashmaroli @DirtyF @jekyllbot