Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize destination of pages, documents and staticfiles #8458

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Memoize destination of pages, documents and staticfiles #8458

merged 2 commits into from
Nov 6, 2020

Conversation

ashmaroli
Copy link
Member

  • This is an optimization change.

Summary

Because multiple calls to the :destination method with the same dest_dir (generally @site.dest) will result in unnecessary computations and allocations.

@ashmaroli ashmaroli added memory-optimization ⚡ Reduced memory usage for the work done micro-optimization Matters only if it is a very large site ¯\_(ツ)_/¯ labels Nov 5, 2020
@ashmaroli ashmaroli changed the title Memoize destination of pages and documents Memoize destination of pages, documents and staticfiles Nov 5, 2020
DirtyF
DirtyF approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test suite does not show a significant gain. 🤷

@ashmaroli
Copy link
Member Author

does not show a significant gain

Hence the label, micro-optimization 😉
@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 920c6f4 into jekyll:master Nov 6, 2020
jekyllbot added a commit that referenced this pull request Nov 6, 2020
@jekyllbot
Update history to reflect merge of #8458 [ci skip]
bcbc451
@ashmaroli ashmaroli removed the bug label Nov 6, 2020
@ashmaroli ashmaroli deleted the memoize-destination branch November 6, 2020 13:05
This was referenced Mar 12, 2021
Closed
Merged
Merged
Merged
Merged
@jekyll jekyll locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age memory-optimization ⚡ Reduced memory usage for the work done micro-optimization Matters only if it is a very large site ¯\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashmaroli @DirtyF @jekyllbot