Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce array allocations from merging categories #8453

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Reduce array allocations from merging categories #8453

merged 1 commit into from
Nov 4, 2020

Conversation

ashmaroli
Copy link
Member

  • This is a 🔨 code refactoring change.

Summary

Call set union on data["categories"] only if it is an Array instead of defaulting to a temporary empty array.

@ashmaroli ashmaroli added the memory-optimization ⚡ Reduced memory usage for the work done label Nov 4, 2020
@ashmaroli
Copy link
Member Author

Thanks :)
@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit bf18b27 into jekyll:master Nov 4, 2020
@ashmaroli ashmaroli removed the bug label Nov 4, 2020
jekyllbot added a commit that referenced this pull request Nov 4, 2020
@jekyllbot
Update history to reflect merge of #8453 [ci skip]
80fce9f
@ashmaroli ashmaroli deleted the reduce-categories-arrays branch November 4, 2020 15:31
This was referenced Mar 12, 2021
Closed
Merged
Merged
Merged
Merged
@jekyll jekyll locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age memory-optimization ⚡ Reduced memory usage for the work done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashmaroli @DirtyF @jekyllbot