-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memoize array of drop getter method names #8421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
added
memory-optimization ⚡
Reduced memory usage for the work done
optimization ⚡
labels
Oct 8, 2020
Third-party Repo Memory Profile Summary--- master https://github.com/jekyll/jekyll/runs/1241364408
+++ PR https://github.com/jekyll/jekyll/runs/1263735861
- Total allocated: 224.63 MB (1271956 objects)
- Total retained: 40.74 MB (130038 objects)
+ Total allocated: 204.96 MB (1193919 objects)
+ Total retained: 40.77 MB (130586 objects) |
DirtyF
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests pass, we can see a slight faster build on the third-party sample repository. 👏
Thank you Frank :) |
jekyllbot
added a commit
that referenced
this pull request
Oct 16, 2020
This was referenced Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
frozen-due-to-age
memory-optimization ⚡
Reduced memory usage for the work done
optimization ⚡
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of stringifying array of drop-instance-methods for every drop instance, compute them once per drop class and reuse the resulting array of strings.