Check if site is in incremental mode optimally #8401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jekyll::Site#incremental?
takes an optional argument which is an empty Hash by default:jekyll/lib/jekyll/site.rb
Lines 367 to 369 in f8c7208
Since the empty hash is a default parameter, every call to the method allocates an empty Hash.
Therefore, calling the method while rendering an include file can allocate numerous Hashes unnecessarily.
The solution is then to access the config value directly.