Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocation from normalize_whitespace filter #8400

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Reduce allocation from normalize_whitespace filter #8400

merged 2 commits into from
Oct 1, 2020

Conversation

ashmaroli
Copy link
Member

  • This is a 🔨 code refactoring.

Summary

Chaining multiple non-mutating methods result in unnecessary duplication.
The solution is to duplicate input once and mutate the result thereafter.

@ashmaroli ashmaroli added the memory-optimization ⚡ Reduced memory usage for the work done label Sep 18, 2020
@ashmaroli ashmaroli added this to the 4.2 milestone Sep 25, 2020
@ashmaroli ashmaroli requested a review from DirtyF October 1, 2020 11:53
DirtyF
DirtyF approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashmaroli
Copy link
Member Author

Thanks.
@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit ecbfa58 into jekyll:master Oct 1, 2020
jekyllbot added a commit that referenced this pull request Oct 1, 2020
@jekyllbot
Update history to reflect merge of #8400 [ci skip]
c9b84e2
@ashmaroli ashmaroli deleted the normalize-whitespace-filter-optimization branch October 1, 2020 13:53
This was referenced Mar 12, 2021
Closed
Merged
Merged
Merged
Merged
@jekyll jekyll locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age memory-optimization ⚡ Reduced memory usage for the work done
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashmaroli @DirtyF @jekyllbot