Check default front matter scope against symbols

[ashmaroli]

• This is a 🔨 code refactoring.

Summary

The type attribute of Jekyll's core convertible classes are Symbols. i.e. Pages are :pages, documents are the parent collection-label symbolized, etc

(The exception being Jekyll::StaticFile and Jekyll::Layout which have type as nil).

Coercing a Symbol (or nil) to String allocates the string to memory on each call. Since this coercion in the code below is only for comparison, we can instead coerce the string values to Symbols and avoid allocating temporary strings:

jekyll/lib/jekyll/frontmatter_defaults.rb

Lines 159 to 161 in 7e0f907

	def applies_type?(scope, type)
	!scope.key?("type") || scope["type"].eql?(type.to_s)
	end

[ashmaroli]

Third Party Repo Profile Summary

--- master
+++ PR

- Total allocated: 282.43 MB (2467827 objects)
+ Total allocated: 281.58 MB (2446531 objects)
  Total retained:  37.81 MB (112069 objects)

[DirtyF]

I don't see any clear gain here: https://github.com/jekyll/jekyll/runs/1129387000?check_suite_focus=true#step:7:18

[ashmaroli]

I've restarted the check-run. Let's see if that makes any difference 😉

[ashmaroli]

The new check run has different timestamps:

--- https://github.com/jekyll/jekyll/runs/1129387000?check_suite_focus=true#step:7:18
+++ https://github.com/jekyll/jekyll/runs/1129680368?check_suite_focus=true#step:7:18

-                    done in 32.912 seconds.
-                    done in 36.238 seconds.
-                    done in 34.763 seconds.
+                    done in 29.318 seconds.
+                    done in 30.575 seconds.
+                    done in 30.011 seconds.

But the memory usage remains the same.

The takeaway is that the build job is an unreliable metric 😅

[ashmaroli]

@jekyllbot: merge +fix