Stash documents write?
attribute in a variable
#8389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of checking
collection&.write? && site.publisher.publish?(self)
on every call to the:write?
method, compute the result once per instance and reuse the result on subsequent calls.Context
document.write?
is invoked via various core classes (e.g.Site
,Regenerator
) and in-house plugins (e.g.jekyll-mentions
,jemoji
)