Add post_convert hook to modify HTML content before layout #8368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: John Hughes <johnkhughes@users.noreply.github.com>
Co-Authored-By: John Hughes <johnkhughes@users.noreply.github.com>
There's a tricky behaviour (bug?) with the "page with content" definition in features/step_definitions.rb. This adds an empty YAML front matter section, so any YAML you include in the step will be appended to this and interpreted as Markdown.
ljcooke
changed the title
|
Thank you for taking this feature to the finish line, @ljcooke
|
|
@ashmaroli Sounds good. 馃憤 Hopefully I'll find time to work on these changes tomorrow. |
Assuming this is OK for now as we're also skipping Metrics/AbcSize here.
|
@ashmaroli I've made those changes. Ready for review again. :) |
ashmaroli
approved these changes
Sep 4, 2020
|
Once again, thank you very much @ljcooke 馃槂 |
|
Awesome, thanks @ashmaroli! |
This was referenced Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 馃檵 feature or enhancement.
Summary
This adds a
post_converthook for plugins to modify the content after converting to HTML but before rendering the page layout.Context
Closes #7271
This was implemented in #4752 and #7271, but the feature specs were unfinished. I've rebased the changes onto
masterand fixed the feature specs.See discussion in #4714 and #4752.