Replace nested conditional with guard clauses #8294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
reviewed
Jul 9, 2020
ashmaroli
reviewed
Jul 9, 2020
|
If you're willing to, the first two lines could be squashed as well: - page = context.registers[:page]
- site = context.registers[:site]
+ page, site = context.registers.values_at(:page, :site) |
It makes sense. We don't need to refer to twice |
|
@jekyllbot: merge +fix |
|
Thank you @torrocus |
jekyllbot
added a commit
that referenced
this pull request
Jul 9, 2020
bamaswade
reviewed
Mar 13, 2021
lib/jekyll/tags/include.rb
Outdated
| @@ -252,21 +252,21 @@ def tag_includes_dirs(context) | |||
| Array(page_path(context)).freeze | |||
| end | |||
|
|
|||
| private | |||
|
|
|||
This was referenced Mar 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is refactoring.
Summary
I wanted to remove the
lib/jekyll/tags/include.rbfile from the exclusion list in.rubocop_todo.yml.But when I looked there, I did a little refactoring.
Now this code is more readable.
Context
It isn't related to any GitHub issue.
The functionality is the same.