Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in documentation section #8265

Merged
merged 1 commit into from Jun 24, 2020
Merged

Fix grammar in documentation section #8265

merged 1 commit into from Jun 24, 2020

Conversation

HonkingGoose
Copy link
Contributor

This is a 🔦 documentation change.

Summary

Change the word 'is' to 'are', because when the subject is plural, we use 'are'.

Context

@ashmaroli ashmaroli changed the title Change word Fix grammar in documentation section Jun 24, 2020
@ashmaroli
Copy link
Member

Thank you for catching and correcting the issue, @HonkingGoose.
For future reference, I recommend providing a short and meaningful commit message for the sake of our Git History.

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

@DirtyF
Copy link
Member

DirtyF commented Jun 24, 2020

@jekyll: merge

@jekyllbot jekyllbot merged commit 3f6e230 into jekyll:master Jun 24, 2020
jekyllbot added a commit that referenced this pull request Jun 24, 2020
@HonkingGoose
Copy link
Contributor Author

@ashmaroli I agree that a good commit message is important! I was not sure what the right commit message should be for one-word changes such as this...

Something like:

"Fix grammar in documentation"

Or:

"Fix grammar, change word "is" to "are"

Or:

"Change word from "is" to "are"

What would you prefer in future?

@ashmaroli
Copy link
Member

I believe "Fix grammar in documentation" summarizes the type of change and the area of code being changed, perfectly — The change is not in one of the lib/ files, or test/ files..

@jekyll jekyll locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants