Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release post for v4.1.1 #8243

Merged
merged 4 commits into from Jun 24, 2020
Merged

Release post for v4.1.1 #8243

merged 4 commits into from Jun 24, 2020

Conversation

ashmaroli
Copy link
Member

Summary

Draft release-post for v4.1.1

DirtyF
DirtyF reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clearly state when it's safe to use page excerpts and when it's not, as here we say OK it's an experimental option now, it might go into an infinite loop but we'll introduce it back in v5.0.

This leaves people wondering when to use the feature or not.

@ashmaroli
Copy link
Member Author

Can we clearly state when it's not safe to use page excerpts..

Done.

@ashmaroli ashmaroli marked this pull request as ready for review June 24, 2020 11:39
@ashmaroli ashmaroli requested a review from DirtyF June 24, 2020 11:39
DirtyF
DirtyF approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a mess 😕

@DirtyF
Copy link
Member

DirtyF commented Jun 24, 2020

@jekyll: merge +site

@jekyllbot jekyllbot merged commit a7b8d27 into jekyll:master Jun 24, 2020
jekyllbot added a commit that referenced this pull request Jun 24, 2020
@jekyllbot
Update history to reflect merge of #8243 [ci skip]
3ec61e6
@ashmaroli ashmaroli deleted the release-post-4.1.1 branch June 24, 2020 18:00
@jekyll jekyll locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
documentation frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashmaroli @DirtyF @jekyllbot