Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make page excerpts consistent with doc excerpts #8236

Merged
merged 3 commits into from Jun 17, 2020
Merged

Make page excerpts consistent with doc excerpts #8236

merged 3 commits into from Jun 17, 2020
+63 −27

Conversation

ashmaroli
Copy link
Member

  • This is a 🐛 bug fix.
  • I've added tests

Summary

  • Document excerpts are extracted before the site's render phase so page excerpts now follow the same trend. This is so that page excerpts don't start with a liquid-evaluated-but-not-converted initial content.
  • Page excerpts need access to pre-computed hash since pages are not using a drop now.
  • Update tests to better reflect behavior.

Context

Resolves #8233

@ashmaroli ashmaroli requested a review from a team June 8, 2020 13:53
@ashmaroli
Copy link
Member Author

@DirtyF Is there something that needs to be changed in this PR?
Once this is in, we can move to release v4.1.1 ..

@DirtyF
Copy link
Member

DirtyF commented Jun 17, 2020

@jekyll: merge +fix

I'll have to trust you on this, didn't take the time to do proper QA. Tests look OK. 😊

@jekyllbot jekyllbot merged commit ba29de0 into jekyll:master Jun 17, 2020
jekyllbot added a commit that referenced this pull request Jun 17, 2020
@jekyllbot
Update history to reflect merge of #8236 [ci skip]
0975bd7
@ashmaroli
Copy link
Member Author

Apologies for rushing you. I thought a week would've sufficed for this change.

@ashmaroli ashmaroli deleted the page-excerpts-parity-doc-excerpts branch June 17, 2020 13:45
@jekyll jekyll locked and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

10x as slow build speed on 4.1.0 than 4.0.1
3 participants
@ashmaroli @DirtyF @jekyllbot