Expect drive letter only on vanilla windows

[ashmaroli]

Summary

Bash on Windows expands similar to paths on Linux

Context

Based on discussion in #8220 with @noproblema
Resolves #8220

[ashmaroli]

@noproblema This patch should resolve your issue, To test at your end, run the following:

git fetch upstream refs/pull/8227/head:vanilla-windows-temp-dirpath
git checkout vanilla-windows-temp-dirpath
bash script/test test/test_site.rb

Let me know if the test passes on your end now.

[noproblema]

Thanks Ashwin. Yes, that solves my issue. But... I stil think that these tests will fail in windows because they will compare "C:/tmp" with "/tmp". Anyway, I don't want to make a full windows installation only to test it. If I'm right you will find it, if not... well, will not be my first nor my last mistake. For me that issue is closed.

[ashmaroli]

Thank you for testing @noproblema
Once again, I'd like to inform you that we're not comparing C:/tmp with /tmp, but that we're testing if the resulting path will be C:/tmp/whatever on Windows and /tmp/whatever on Unix-based platforms.

[ashmaroli]

@jekyllbot: merge +dev

[noproblema]

Thanks Ashwin I think that we are not talking about the same test. Below the one that I'm talking about and that is bugging me: should "have an array for plugins if passed as an array" do site = Site.new(site_configuration( "plugins_dir" => ["/tmp/plugins", "/tmp/otherplugins"] )) array = [temp_dir("plugins"), temp_dir("otherplugins")] assert_equal array, site.plugins end > we're not comparing C:/tmp with /tmp, As I read the code it compares ["/tmp/plugins", "/tmp/otherplugins"] with [temp_dir("plugins"), temp_dir("otherplugins")] as site_configuration only stores the values, don't change them. I can't understand how that test passes in windows. On Wednesday, June 3, 2020, 05:46:21 PM GMT+2, Ashwin Maroli <notifications@github.com> wrote: Thank you for testing @noproblema Once again, I'd like to inform you that we're not comparing C:/tmp with /tmp, but that we're testing if the resulting path will be C:/tmp/whatever on Windows and /tmp/whatever on Unix-based platforms. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[ashmaroli]

@noproblema You yourself told me a couple of days ago that with the proposed change here, the tests pass successfully on your computer. Ergo, the tests should pass with the latest master now that this has been merged.

I will clarify it for you one last time and continued queries will be ignored.

The test code you're referring to is:

jekyll/test/test_site.rb

Lines 39 to 45 in 81c1350

	should "have an array for plugins if passed as an array" do
	site = Site.new(site_configuration(
	"plugins_dir" => ["/tmp/plugins", "/tmp/otherplugins"]
	))
	array = [temp_dir("plugins"), temp_dir("otherplugins")]
	assert_equal array, site.plugins
	end

The fixture site used in the test is configured to point to an array of paths. The config translates to the following YAML data (simulating what the hypothetical user has given Jekyll):

plugins_dir:
- "/tmp/plugins"
- "/tmp/otherplugins"

On Unix based platforms (and apparently on Bash on Windows, too), Jekyll processes the above configuration as Ruby array:

["/tmp/plugins", "/tmp/otherplugins"]

On pure Windows platform, Jekyll processes the above configuration into Ruby array based on the current drive the user's source directory is:

["C:/tmp/plugins", "C:/tmp/otherplugins"]

What the test-helper method temp_dir() does is to take the given strings and join them to <root>/tmp/. Agreed that it is not a very robust and flexible implementation. But it serves the purpose.

Therefore, the code [temp_dir("plugins"), temp_dir("otherplugins")] will evaluate into ["C:/tmp/plugins", "C:/tmp/otherplugins"] and ["/tmp/plugins", "/tmp/otherplugins"] on pure Windows platforms and on other platforms respectively. The test passes on all platforms because the test helper adapts results based on the platform (which mirrors the value of site.plugins on that platform).

If it is still not clear, you probably need to brush up on your Ruby and programming skills.