Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert introduction of PageDrop #8221

Merged
merged 2 commits into from Jun 4, 2020
Merged

Conversation

ashmaroli
Copy link
Member

Summary

This reverts commit b84ba5a.

The Jekyll ecosystem is not fully compatible with the migration.
Due to long-term use of the legacy implementation, the migration has ended up being a breaking-change.

Context

Resolves #8219

@ashmaroli ashmaroli marked this pull request as ready for review June 4, 2020 09:22
@ashmaroli ashmaroli requested a review from DirtyF June 4, 2020 09:22
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@DirtyF
Copy link
Member

DirtyF commented Jun 4, 2020

Hopes it makes its way back in Jekyll 5.0 🤞

@ashmaroli
Copy link
Member Author

Hopes it makes its way back in Jekyll 5.0

As easy as reverting the merge commit here and resolving any conflicts 😉

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 8590ab0 into jekyll:master Jun 4, 2020
jekyllbot added a commit that referenced this pull request Jun 4, 2020
@jekyll jekyll locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.1.0: Liquid Exception: stack level too deep
3 participants