Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize static files' data hash only if needed #8188

Merged
merged 1 commit into from May 25, 2020

Conversation

ashmaroli
Copy link
Member

Summary

Instead of initializing a static file's data hash at the time the static file is read-in, initialize the data hash at a later time if required.

This can improve performance of sites with numerous static files and default front matter in the config file.

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable build gain: 4.2s vs 5.2s on Jekyll's website 👍

@DirtyF
Copy link
Member

DirtyF commented May 25, 2020

@jekyll: merge +minor

@jekyllbot jekyllbot merged commit c0fde30 into jekyll:master May 25, 2020
jekyllbot added a commit that referenced this pull request May 25, 2020
@ashmaroli ashmaroli deleted the lazy-load-static-file-data branch May 25, 2020 16:29
@jekyll jekyll locked and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants