Provide invokables for common drop query keys #8165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory Profile--- master https://travis-ci.org/github/jekyll/jekyll/jobs/684126964
+++ PR https://travis-ci.org/github/jekyll/jekyll/jobs/684634377
- Total allocated: 298.04 MB (3049942 objects)
- Total retained: 19.40 MB (108644 objects)
+ Total allocated: 296.24 MB (3004828 objects)
+ Total retained: 19.40 MB (108643 objects) |
|
@jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While playing around with profilers, it noticed that memory allocations are greater when a
Dropqueried with a key doesn't have a method defined for the key and is therefore forwarded to queryfallback_data.So, this PR provides commonly queried keys as methods defined for the drops.