Optimize path sanitization of default front matter #8154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
String#gsub
duplicates the given string irrespective of a pattern match.So, it is better if one checks if a given string will match the pattern beforehand and return the original string if it doesn't match the pattern.
Regarding the pattern,
%r!\A/|(?<=[^/])\z!
, it translates toTest if a given string either starts with
/
or just match theend-of-string
preceded by a character that is not/
.The second option of the regex will always generate a match for the major use-cases
(e.g.
scope["path"] == "pages"
orscope["path"] == "\pages"
)So we can optimize for the major use-cases by checking if the given string
start_with?
"/"
prior to thegsub
call.