New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use platforms instead of install_if #8140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dleidert We also have a similar usage in our dev Gemfile. Could you patch those lines as well..? Lines 83 to 88 in 2bc1e04
|
@DirtyF Do you think this patch qualifies to be backported for v4.0.x..? |
@ashmaroli Not if we release 4.1 sooner than later. As you see fit. |
@jekyll: merge +fix |
With :install_if bundler will check for the gems even if they are not required
on our platform. To prevent users from having this issue use :platforms
instead: https://lists.debian.org/debian-ruby/2020/04/msg00062.html
fixes #8139