Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slugified_categories URL placeholder #8094

Merged
merged 2 commits into from Apr 13, 2020
Merged

Add slugified_categories URL placeholder #8094

merged 2 commits into from Apr 13, 2020

Conversation

ashmaroli
Copy link
Member

  • This is a 馃檵 feature or enhancement.
  • I've added tests.
  • I've updated the documentation.
  • The test suite passes locally.

Summary

This allows generation of URLs without %20 when a singular category is a composite of multiple words.

Context

Resolves #8093

@ashmaroli ashmaroli requested a review from a team April 3, 2020 15:02
@ashmaroli ashmaroli added this to the 4.1 milestone Apr 3, 2020
@ashmaroli ashmaroli force-pushed the slugified-categories-url-placeholder branch from aae5638 to 87e3540 Compare April 3, 2020 16:09
DirtyF
DirtyF approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憣 Perfect!

@DirtyF
Copy link
Member

DirtyF commented Apr 13, 2020

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 30e7d5e into jekyll:master Apr 13, 2020
jekyllbot added a commit that referenced this pull request Apr 13, 2020
@jekyllbot
Update history to reflect merge of #8094 [ci skip]
b146257
@ashmaroli ashmaroli deleted the slugified-categories-url-placeholder branch April 13, 2020 10:11
@jekyll jekyll locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug feature fix frozen-due-to-age
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

feat: slugify :categories permalink
3 participants
@ashmaroli @DirtyF @jekyllbot