Simplify Jekyll::Renderer#validate_layout
#8064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
approved these changes
Mar 22, 2020
|
@jekyllbot: merge +fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if a rendering document's layout is valid and not
nil,layout_sourceis computed even if the build is not running ondebuglog level.Additionally when building with
--verbose,Layout source: ...is output for every rendered document placed into a layout. That can be considered noise because when 10 documents use the same layout, outputtingLayout source: ...for each of them is repetition.Finally, when a layout is not from
site.source, it is currently assumed to be from the theme, when in reality, it could be from a plugin (likejekyll-redirect-from).Therefore, instead of checking if a layout comes from
site.sourceor enhance to test if it comes from a theme or plugin, I propose removing that conditional branch entirely.