Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple binary operators in where_exp filter #8047

Merged
merged 1 commit into from Mar 6, 2020
Merged

Allow multiple binary operators in where_exp filter #8047

merged 1 commit into from Mar 6, 2020

Conversation

ashmaroli
Copy link
Member

  • This is a 馃悰 bug fix.
  • I've added tests.
  • The test suite passes locally.

Summary

Allow filtering with expressions involving multiple use of and or or.

Context

Resolves #8046

@ashmaroli ashmaroli added the fix label Mar 6, 2020
DirtyF
DirtyF approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@ashmaroli ashmaroli requested a review from a team March 6, 2020 16:07
@DirtyF
Copy link
Member

DirtyF commented Mar 6, 2020

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 0f4c8d2 into jekyll:master Mar 6, 2020
@jekyllbot jekyllbot added the bug label Mar 6, 2020
jekyllbot added a commit that referenced this pull request Mar 6, 2020
@jekyllbot
Update history to reflect merge of #8047 [ci skip]
27ca063
@ashmaroli ashmaroli deleted the where-exp-multiple-branches branch March 6, 2020 16:17
@jekyll jekyll locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Where_exp not working with more than 2 operators
3 participants
@ashmaroli @DirtyF @jekyllbot