Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Jekyll::Hooks.trigger logic #8044

Merged
merged 1 commit into from Mar 4, 2020
Merged

Simplify Jekyll::Hooks.trigger logic #8044

merged 1 commit into from Mar 4, 2020

Conversation

ashmaroli
Copy link
Member

Summary

  • Use Hash#dig to traverse nested hashes and check if the result is nil.
  • Guard against empty object as well so that we need not consequently duplicate it via :sort_by.

@mattr-
Copy link
Member

mattr- commented Mar 4, 2020

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit ea57ef7 into jekyll:master Mar 4, 2020
jekyllbot added a commit that referenced this pull request Mar 4, 2020
@jekyllbot
Update history to reflect merge of #8044 [ci skip]
ab6ef0b
@ashmaroli ashmaroli deleted the refactor-hooks-trigger branch March 4, 2020 15:50
@jekyll jekyll locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattr- mattr- mattr- approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashmaroli @mattr- @jekyllbot