Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documents custom-ordering logic #8028

Merged
merged 1 commit into from Mar 12, 2020
Merged

Fix documents custom-ordering logic #8028

merged 1 commit into from Mar 12, 2020

Conversation

ashmaroli
Copy link
Member

  • This is a 馃悰 bug fix.
  • The test suite passes locally.

Summary

Check for nil values before checking for zero value since nil doesn't respond to :zero?

Context

Closes #8024

@ashmaroli ashmaroli added this to the 4.1 milestone Feb 26, 2020
@ashmaroli ashmaroli added the fix label Feb 26, 2020
DirtyF
DirtyF approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槄

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit f826b8b into jekyll:master Mar 12, 2020
@jekyllbot jekyllbot added the bug label Mar 12, 2020
@ashmaroli ashmaroli deleted the fix-docs-ordering-logic branch March 12, 2020 14:58
jekyllbot added a commit that referenced this pull request Mar 12, 2020
@jekyllbot
Update history to reflect merge of #8028 [ci skip]
88360bd
@jekyll jekyll locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Collection sorting breaks with number ids ending with the numbers 8 or 9
3 participants
@ashmaroli @DirtyF @jekyllbot