Return relative_url if site.url is an empty string #7988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when
site.config["url"]
is an empty string,:absolute_url
proceeds to prepend the result from:relative_url
with the empty string and then normalize the result via Addressable.Instead, this PR proposes to return the result from
:relative_url
(which is already normalized via Addressable) in this scenario.Coverage
The expected result is already covered by a test:
jekyll/test/test_filters.rb
Lines 421 to 428 in f3b4cad