Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear cached Liquid template scope before render #7967

Merged
merged 2 commits into from Apr 13, 2020
Merged

Clear cached Liquid template scope before render #7967

merged 2 commits into from Apr 13, 2020

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Jan 8, 2020 •
edited

  • This is a 馃悰 bug fix.
  • No unit-tests.

Summary

Since Liquid::Templates are now cached, ensure that every render starts with a clean context.

Context

Resolves #7811

@ashmaroli ashmaroli marked this pull request as ready for review January 12, 2020 10:07
@ashmaroli ashmaroli added the fix label Jan 12, 2020
@ashmaroli ashmaroli added this to the 4.1 milestone Jan 12, 2020
@ashmaroli ashmaroli requested review from a team January 12, 2020 10:09
@letrastudio letrastudio mentioned this pull request Feb 8, 2020
Closed
DirtyF
DirtyF approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槄

@DirtyF
Copy link
Member

DirtyF commented Apr 13, 2020

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 67380a2 into jekyll:master Apr 13, 2020
@jekyllbot jekyllbot added the bug label Apr 13, 2020
jekyllbot added a commit that referenced this pull request Apr 13, 2020
@jekyllbot
Update history to reflect merge of #7967 [ci skip]
6db5066
@ashmaroli ashmaroli deleted the clear-template-assigns branch April 26, 2020 08:53
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Apr 26, 2020
@ashmaroli
Backport jekyll#7967 for v4.0.x
ab77046 
Clear cached Liquid template scope before render
This backports 67380a2 to 4.0-stable
ashmaroli added a commit that referenced this pull request Apr 26, 2020
@ashmaroli
Backport #7967 for v4.0.x (#8141)
de89a60 
Clear cached Liquid template scope before render
This backports 67380a2 to 4.0-stable
@arthurattwell arthurattwell mentioned this pull request Jan 16, 2021
Closed
@jekyll jekyll locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age priority 1 (must)
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Jekyll 4.0 gets confused about page variables
3 participants
@ashmaroli @DirtyF @jekyllbot