Add an option to easily disable disk-cache #7928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
approved these changes
Dec 5, 2019
|
@ashmaroli 馃憤 for the implementation, tests should pass though |
Mercenary interprets `--no-*` as a falsy. But we need `disable_disk_cache` to have a truthy value instead.
|
@jekyllbot: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 馃檵 feature or enhancement.
Summary
Running in
safemode just to disable Jekyll 4.0's disk-caching seems like an overkill.Plugins would need to be modified to be compatible with
safemode, whitelist gems...With this change one can disable disk-cache in non-safe mode via either
--disable-disk-cacheCLI switch ordisable_disk_cache: trueconfiguration.Context
Closes #7804
/cc @Convincible