Add static file's basename to its url_placeholder #7908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jekyll: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Apr 13, 2020
ashmaroli
added a commit
to ashmaroli/jekyll
that referenced
this pull request
Apr 26, 2020
Add static file's basename to its url_placeholder This backports be70c3e to 4.0-stable
ashmaroli
added a commit
that referenced
this pull request
Apr 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jekyll 4.0 introduced a minor change (via #7315) in how URLs for static files were generated whereby the logic for static files in a collection became more responsive to the associated collection's
url_template. So when a collection'surl_templateis customized at client-side to utilize:name, static files should adapt accordingly.Context
Resolves #7904