New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include _config.yml in a new theme's gemspec #7865
Conversation
Thank you for submitting this @bigelowcc. Regarding tests, we currently cover this aspect via Cucumber features. As for the proposed change, the feature is currently limited to just loading |
Jekyll 4.0 only loads a `_config.yml` at the root of the theme_dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not merging this right away since we need to decide if Jekyll should bundle |
If you're packaging a theme as a gem, we should make it easiest for the user to use the gem by default. Theme authors should opt-out. @jekyllbot: merge +minor |
Note to myself: Ensure that this is mentioned in the v4.1.0 release-post since novice users won't realize they're bundling their config file right away. |
This is a 馃悰 bug fix.
Summary
#7304 introduced loading the
_config.yml
from a theme, but the gemspec doesn't include this file.Currently a site will correctly include values from the theme's
_config.yml
locally, but not once the theme is packaged and pulled from a gem repository, as the file doesn't exist.This PR adds
_config.yml
to the gemspec generated when you runjekyll new-theme
.Context
#7304 introduced this feature.
Notes
_config.yml