Memoize absolute_url and relative_url filters #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
reviewed
Aug 19, 2019
|
Thanks |
benesch
force-pushed
the
fast-url-filters
branch
from
8ce5a12
to
c5535f3
Compare
DirtyF
reviewed
Aug 20, 2019
benesch
force-pushed
the
fast-url-filters
branch
from
c5535f3
to
926f05f
Compare
|
Whoops, done. Had to refactor a bit to get the AbcSize lint to quiet down. |
These two filters are quite slow, as Addressable::URI.parse is quite slow. Fortunately, they are pure functions and so can be easily memoized. This one change shaves 8s off the CockroachDB docs build (github.com/cockroachdb/docs).
benesch
force-pushed
the
fast-url-filters
branch
from
926f05f
to
a4a6678
Compare
parkr
approved these changes
Aug 22, 2019
|
Thanks @benesch 👍 @jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Aug 22, 2019
This was referenced Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two filters are quite slow, as Addressable::URI.parse is quite
slow. Fortunately, they are pure functions and so can be easily
memoized. This one change shaves 8s off the CockroachDB docs build
(github.com/cockroachdb/docs).