New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Jekyll::Filters#item_property #7696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Profiler Summary--- master branch https://travis-ci.org/jekyll/jekyll/jobs/567626937
+++ PR branch https://travis-ci.org/jekyll/jekyll/jobs/571688230
- Total allocated: 485.18 MB (4549242 objects)
- Total retained: 19.16 MB (100616 objects)
+ Total allocated: 481.26 MB (4489114 objects)
+ Total retained: 19.17 MB (100692 objects) |
DirtyF
approved these changes
Aug 14, 2019
mattr-
reviewed
Feb 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if we can get the test suites to pass. 😅
All green 🍏 @jekyllbot: merge +fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
property.split(".").reduce(liquid_data)
only ifproperty
is a dot-notation string.Otherwise,
property
need not besplit
into a single-element array just to be reduced with theliquid_data
object.liquid_data.respond_to?(:[]) && liquid_data[key]
.Since a first-pass to
:reduce
can result innil
, a subsequent pass should be guarded.e.g. when
property == "author.name"
andpage.author == nil
property = property.to_s
instead of multipleproperty.to_s
#parse_sort_input
at the end of method instead of placing a call at end of each conditional branchContext
Resolves #6939
Closes #6992