Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out exclusively excluded entries sooner #7482

Merged
merged 5 commits into from May 20, 2020
Merged

Filter out exclusively excluded entries sooner #7482

merged 5 commits into from May 20, 2020

Conversation

ashmaroli
Copy link
Member

Summary

  • If a path is listed in the exclude array and in the include array, proceed to check if the path is a symlink or special or a backup file.
  • If a path is listed only in the exclude array, then reject it right away.
  • Otherwise reject a path only if it is a symlink or special or a backup file

Context

Resolves #7481

@ashmaroli ashmaroli requested review from parkr and a team January 18, 2019 16:21
@update-docs

This comment has been minimized.

Sign in to view
DirtyF
DirtyF approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashmaroli ashmaroli removed request for a team and parkr May 20, 2020 11:22
@ashmaroli
Copy link
Member Author

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 696e8e4 into jekyll:master May 20, 2020
jekyllbot added a commit that referenced this pull request May 20, 2020
@jekyllbot
Update history to reflect merge of #7482 [ci skip]
881fdc1
@ashmaroli ashmaroli deleted the filter-excludes-sooner branch May 20, 2020 11:44
@jekyll jekyll locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken excluded symlink throws error
3 participants
@ashmaroli @DirtyF @jekyllbot