Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #7250 to 3.8.x #7352

Merged
3 commits merged into from Nov 4, 2018
Merged

Backport #7250 to 3.8.x #7352

3 commits merged into from Nov 4, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2018 •
edited by DirtyF

backport #7250

@ghost ghost requested a review from ashmaroli November 4, 2018 19:08
@DirtyF DirtyF added the fix label Nov 4, 2018
@DirtyF DirtyF added this to the 3.8.5 milestone Nov 4, 2018
@ashmaroli ashmaroli added the ⏪ backport Changes will be merged into an older stable branch label Nov 4, 2018
@ghost
Copy link
Author

ghost commented Nov 4, 2018

Not sure why neither Travis nor AppVeyor are responding...

@ashmaroli
Copy link
Member

Not sure why neither Travis nor AppVeyor are responding...

There's an error in the configs.. /*-stable/ is not a valid regexp..

@ghost
Copy link
Author

ghost commented Nov 4, 2018

@ashmaroli I (think) I've fixed it on master, but AppVeyor doesn't have a branch limitation configuration option, does it?

@DirtyF
Copy link
Member

DirtyF commented Nov 4, 2018 •
edited

856 tests, 1533 assertions, 0 failures, 0 errors, 3 skips

Tests are now passing locally, they were a few style offenses.

@ashmaroli
Copy link
Member

I (think) I've fixed it on master, but AppVeyor doesn't have a branch limitation configuration option, does it?

backport-.* is not needed actually.. but doesn't matter..
AppVeyor only builds master and themes branches..

@ghost ghost merged commit a7e8f08 into 3.8-stable Nov 4, 2018
@DirtyF DirtyF deleted the 3.8-backport-7250 branch November 4, 2018 19:55
@jekyll jekyll locked and limited conversation to collaborators Nov 4, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
fix frozen-due-to-age ⏪ backport Changes will be merged into an older stable branch
Projects
None yet
Milestone
3.8.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashmaroli @DirtyF @jekyllbot