Skip to content

feat: enhance --blank scaffolding #7310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 12, 2018
Merged

feat: enhance --blank scaffolding #7310

merged 9 commits into from
Oct 12, 2018
+63 −6

Conversation

jekyllbot
Copy link
Contributor

@jekyllbot jekyllbot commented Oct 10, 2018 •
edited by DirtyF
Loading

Fix #5260

Context

Current blank template could be enhanced so that users can start developing right away.

As a developer
I want to be able to start developing a Jekyll site from scratch with default scaffolding

Given I start a new Jekyll project
When I run `bundle exec jekyll new SITENAME --blank`
Then I can start developing from a complete default scaffolding:
├── _config.yml
├── _data
├── _drafts
├── _includes
├── _layouts
│   └── default.html
├── _posts
├── _sass
│   └── main.scss
├── assets
│   └── css
│       └── main.scss
└── index.html

Demo

asciicast

@DirtyF
feat: enhance --blank scaffolding

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
5f16575
@DirtyF DirtyF requested a review from a team October 10, 2018 15:28
@DirtyF DirtyF added this to the 4.0 milestone Oct 10, 2018
@DirtyF

This comment has been minimized.

Sign in to view
@ashmaroli

This comment has been minimized.

Sign in to view
ashmaroli
ashmaroli reviewed Oct 10, 2018
View reviewed changes
@DirtyF
feat: add default layout to --blank

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
b4c7e0c
@ashmaroli ashmaroli changed the title feat: enhance --blank scaffolding WIP: Feature: enhance --blank scaffolding Oct 10, 2018
@mattr-

This comment has been minimized.

Sign in to view
@mattr-

This comment has been minimized.

Sign in to view
@DirtyF
feat: add blank_template

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
4b81d47
@DirtyF DirtyF changed the title WIP: Feature: enhance --blank scaffolding Feature: enhance --blank scaffolding Oct 10, 2018
@DirtyF
feat: scaffold blank_template

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
4b313dc
DirtyF added 2 commits October 10, 2018 19:25
@DirtyF
tests: blank site scaffolding scenario

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
9d1e41f
@DirtyF
tests: create blank project

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
c3a0bb8
@DirtyF DirtyF mentioned this pull request Oct 10, 2018
Closed
1 task
DirtyF added 2 commits October 10, 2018 20:41
@DirtyF
feat: add default empty directories

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
0584ca0
@DirtyF
docs: new --blank command usage [ci-skip]

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
59c8696
@lukepighetti
Copy link

Glad to see this PR. Thanks for the hard work!

ashmaroli
ashmaroli approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
The Cucumber features could additionally test if the generated files are not just empty entities..
But that can be handled in another PR..

@ashmaroli

This comment has been minimized.

Sign in to view
@DirtyF
refactor: add default empty directories

Verified

This commit was signed with the committer’s verified signature.
DirtyF Frank Taillandier
GPG key ID: E73258E3F50AEB7E
Verified
Learn about vigilant mode
4537a61
@DirtyF DirtyF changed the title Feature: enhance --blank scaffolding feat: enhance --blank scaffolding Oct 11, 2018
@ghost
Copy link

ghost commented Oct 12, 2018

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 37baaec into master Oct 12, 2018
@jekyllbot jekyllbot deleted the pull/new--blank branch October 12, 2018 10:57
jekyllbot added a commit that referenced this pull request Oct 12, 2018
@jekyllbot
Update history to reflect merge of #7310 [ci skip]
749415c
@jekyll jekyll locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF

@ashmaroli ashmaroli

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

New option: create a blank site, without a template by default
5 participants
@jekyllbot @DirtyF @ashmaroli @mattr- @lukepighetti