Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redgreen gem #6720

Merged
merged 1 commit into from Jan 25, 2018
Merged

Remove redgreen gem #6720

merged 1 commit into from Jan 25, 2018

Conversation

yous
Copy link
Contributor

@yous yous commented Jan 25, 2018

This is a reflect of #204, 093a5ef.

About redgreen:

I found that redgreen is installed by running rg command. It stands for ripgrep now, at least for me.

ashmaroli
ashmaroli approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing.. so 👍

DirtyF
DirtyF approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yous 😄

@DirtyF
Copy link
Member

DirtyF commented Jan 25, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 731960e into jekyll:master Jan 25, 2018
jekyllbot added a commit that referenced this pull request Jan 25, 2018
@jekyllbot
Update history to reflect merge of #6720 [ci skip]
c9d2da8
@yous yous deleted the remove-redgreen branch January 25, 2018 15:57
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yous @DirtyF @ashmaroli @jekyllbot