Update plugins.md #6716
Merged
Update plugins.md #6716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
approved these changes
Jan 25, 2018
ashmaroli
reviewed
Jan 25, 2018
docs/_docs/plugins.md
Outdated
| @@ -920,7 +920,7 @@ You can find a few useful plugins at the following locations: | |||
|
|
|||
| #### Other | |||
|
|
|||
| - [Analytics for Jekyll](https://github.com/hendrikschneider/jekyll-analytics) by Hendrik Schneider: An effortless way to add various trackers like Google Analytics, Piwik, etc. to your site | |||
| - [Analytics for Jekyll](https://github.com/hendrikschneider/jekyll-analytics) by Hendrik Schneider: An effortless way to add various trackers like Google Analytics, Piwik, Matomo, MPulse, etc. to your site | |||
There was a problem hiding this comment.
- Piwik is now Matomo.. so it should not be Piwik, Matomo
- All docs refer to "MPulse" as "mPulse"
- trackers like Google Analytics, Piwik, Matomo, MPulse, etc. to your site
+ trackers like Google Analytics, Matomo (Piwik), mPulse, etc. to your siteThere was a problem hiding this comment.
I think it is also important to mention Piwik to show backwards compatibility. Would you accept this description?
An effortless way to add various trackers like Google Analytics,
Matomo (former Piwik), mPulse, etc. to your site.
There was a problem hiding this comment.
yes.. I'm fine with adding an adjective.. formerly sounds more apt though..
ghost
approved these changes
Jan 25, 2018
docs/_docs/plugins.md
Outdated
| @@ -920,7 +920,7 @@ You can find a few useful plugins at the following locations: | |||
|
|
|||
| #### Other | |||
|
|
|||
| - [Analytics for Jekyll](https://github.com/hendrikschneider/jekyll-analytics) by Hendrik Schneider: An effortless way to add various trackers like Google Analytics, Piwik, etc. to your site | |||
| - [Analytics for Jekyll](https://github.com/hendrikschneider/jekyll-analytics) by Hendrik Schneider: An effortless way to add various trackers like Google Analytics, Matomo (former Piwik), mPulse, etc. to your site. | |||
There was a problem hiding this comment.
This should say formerly instead of former.
|
@jekyllbot: merge +docs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated plugin description