Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint file and bump theme dependencies #6698

Merged
merged 1 commit into from Jan 19, 2018
Merged

Lint file and bump theme dependencies #6698

merged 1 commit into from Jan 19, 2018

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Jan 17, 2018 •
edited

Default new-theme .gemspec should inherit Jekyll's Ruby Style Guide.

@DirtyF DirtyF requested a review from a team January 17, 2018 12:48
Crunch09
Crunch09 approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@Crunch09 Crunch09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ashmaroli ashmaroli added this to the v3.8.0 milestone Jan 19, 2018
@DirtyF
Copy link
Member Author

DirtyF commented Jan 19, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7a78da8 into master Jan 19, 2018
@jekyllbot jekyllbot deleted the theme-gemspec branch January 19, 2018 15:50
jekyllbot added a commit that referenced this pull request Jan 19, 2018
@jekyllbot
Update history to reflect merge of #6698 [ci skip]
5923160
@ashmaroli
Copy link
Member

@DirtyF Did you intend to ship this in the upcoming patch release 3.7.1?

@ashmaroli ashmaroli removed this from the v3.8.0 milestone Jan 19, 2018
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Crunch09 Crunch09 Crunch09 approved these changes

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal themes 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DirtyF @ashmaroli @Crunch09 @jekyllbot