Release v3.7.1 #6695

ashmaroli · 2018-01-15T09:22:31Z

Fix timezone incosistencies between different ruby version #6697
Refactor collections_dir feature for consistency #6685
Glob scope path only if configured with a pattern #6692
Draft Release Post
- bump date
- mention all contributors
- add links to ours docs

DirtyF

Do we measure the consequences of moving posts in collection_dir for plugins?

DirtyF · 2018-01-15T09:43:20Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+    of the said directory. <br />
+    We addressed this by having Jekyll scan the directory path only if the user
+    explicitly configures the `scope["path"]` using wildcards. <br />
+    Read our documentation for more details. <br />


Working on a document to attach to the associated PR.. will update after it gets merged..

Are all the <br /> tags necessary? Can't we use Markdown line breaks?

Markdown (or GFM, not sure..) converts \n\s* into \s and \n\n into \n<p>
I wanted to just insert simple breaks.. I'll locally "preview" the document once more and adopt the better outcome..

Link to the docs is still missing here.

DirtyF · 2018-01-15T09:44:00Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+
+Close on the heels of shipping 3.7.0, we were informed of a couple of
+regressions due to the changes made in that release. In due time, Team Jekyll
+set out to address those issues as early as possible.


Link to Jekyll teams ?

I was referring to the team of maintainers instead of a particular team..
so do you want me to link to affinity-team-captains here?

As Jekyll need more contributors, linking to teams is meant as a way of reminding that people are welcome to join.

isn't Team Jekyll meant kind of tongue-in-cheek here? at least that's how i interpreted it, but a link to jekyll teams would be nice, agreed

I did not intend it to be tongue-in-cheek at all..:
I just meant to refer to the maintainers of the codebase without focusing on a particular team or set of individuals..

DirtyF · 2018-01-15T09:47:41Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+    Props to @localheinz for asserting this regression to our notice. <br />
+    We decided to resolve this by having Jekyll ignore posts and drafts at the
+    root of the site's source directory *if the user customizes the
+    `collection_dir` setting.* <br />


Moving _posts and _draftsout of the source directory is a tempting fix but can't it have consequences on how some plugins work ?

I'd love it if you can point me to at least one popular plugin that could break.. (not a challenge.., I'd really like to see if there's a workaround / resolution..)

I was thinking of paginationv2, jekyll-admin, jekyll-feed to name a few

IIRC, jekyll-feed, jekyll-sitemap calls to posts via {% for post in site.posts %}. Since Document attributes do not change at all, (relative_path is the same irrespective of the collection_dir) setting, I doubt these plugins are going to break..
But what is evident from jekyll/jekyll-feed#202 is that plugins will break if the posts are at the root directory when a custom collection_dir has been set.

pathawks · 2018-01-15T18:00:31Z

I think #6685 is minor rather than bug-fix

This should be 3.8.0?

ashmaroli · 2018-01-15T18:05:21Z

#6685 is a minor ? Its not introducing any new features / public_methods.. just fixing stuff that broke in 3.7.0..

pathawks · 2018-01-16T00:06:12Z

It requires moving _posts/. Perhaps it is a bug fix, but it might require user intervention and I’d rather err on the side of letting users know when things may have changed.

ashmaroli · 2018-01-16T03:40:49Z

Things actually changed in v3.7.0.. User intervention is required (to customize the collections_dir setting) on v3.7.0 and master even..
./_posts/2018-01-15-test-post.md will get generated into ./_site/_posts/2018/01/15/test-post.html with a custom collections_dir even on master! (which is the bug actually..)

The PR is just normalizing things again.. mitigating confusion....

pathawks · 2018-01-17T16:58:05Z

I follow. In that case, I’m on board with bug-fix 👍

Thanks for taking the time to explain 🍻

ghost · 2018-01-22T15:48:53Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+regressions due to the changes made in that release. In due time, Team Jekyll
+set out to address those issues as early as possible.
+
+Days later, here we're announcing 3.7.1 that aims to set things in order. The


unneccessary use of here

also: can you replace set things in order with set things right? i think it's a more common idiom

here in ln#13 is an extension to the previous sentence..

A week ago, we set out to vanquish our enemies.. And now, here we're, breaking bread with them..

fair enough!

ghost · 2018-01-22T15:50:20Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+    that directory for any subfolders and files, for each document in that
+    `path`.
+    Though this is intended, it increases build times in proportion to the size
+    of the said directory. <br />


said can be removed

ghost · 2018-01-22T15:51:00Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+    explicitly configures the `scope["path"]` using wildcards. <br />
+    Read our documentation for more details. <br />
+    A huge shout-out to @mmistakes for bringing this to our notice and
+    additionally providing with a test repository to aid in resolving the issue.


providing us

ghost · 2018-01-22T15:51:38Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+    Users setting `collection_dir` to a certain directory would have *altered*
+    paths to their posts still at the root of their site's source. This
+    roughly translated to 404 errors on URLs to their posts. <br />
+    Props to @localheinz for asserting this regression to our notice. <br />


i think replacing asserting with bringing is more readable

DirtyF · 2018-01-25T16:05:50Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+have been made that should improve your Jekyll experience. All of which would
+not have been possible without our wonderful contributors: Andreas Möller,
+Ashwin Maroli, Florian Thomas, Frank Taillandier, Olivia and Parker Moore.
+


Update to : Alexandr, Andreas Möller, Ashwin Maroli, Florian Thomas, Frank Taillandier, Kacper Duras, Olivia, Parker Moore, Paul Robert Lloyd

DirtyF · 2018-01-25T16:06:41Z

docs/_posts/2018-01-15-jekyll-3-7-1-released.md

+    of the said directory. <br />
+    We addressed this by having Jekyll scan the directory path only if the user
+    explicitly configures the `scope["path"]` using wildcards. <br />
+    Read our documentation for more details. <br />


Link to the docs is still missing here.

…e-3-7-1

ghost · 2018-01-25T17:09:37Z

docs/_posts/2018-01-25-jekyll-3-7-1-released.md


  * A major regression in 3.7.0 was that when a Front Matter Default was
    configured with a `scope["path"]` set to a directory, Jekyll would scan
    that directory for any subfolders and files, for each document in that
    `path`.
    Though this is intended, it increases build times in proportion to the size
-    of the said directory. <br />
+    of the said.


of the directory

ghost · 2018-01-25T18:04:16Z

@jekyllbot: merge +docs

add release post for v3.7.1

8b42caf

ashmaroli requested a review from a team January 15, 2018 09:22

ashmaroli added the release Time to cut a new gem! label Jan 15, 2018

ashmaroli force-pushed the release-3-7-1 branch from 697a330 to 8b42caf Compare January 15, 2018 09:26

DirtyF reviewed Jan 15, 2018

View reviewed changes

ghost suggested changes Jan 22, 2018

View reviewed changes

DirtyF requested changes Jan 25, 2018

View reviewed changes

ashmaroli added 2 commits January 25, 2018 21:39

Merge branch 'master' of https://github.com/jekyll/jekyll into releas…

e66c5cd

…e-3-7-1

Update Release Post

4547c85

ghost reviewed Jan 25, 2018

View reviewed changes

correct typo

21b9fa1

ghost approved these changes Jan 25, 2018

View reviewed changes

DirtyF approved these changes Jan 25, 2018

View reviewed changes

ashmaroli changed the title ~~WIP: Release v3.7.1~~ Release v3.7.1 Jan 25, 2018

jekyllbot merged commit 5ca193e into jekyll:master Jan 25, 2018

jekyllbot added the documentation label Jan 25, 2018

jekyllbot added a commit that referenced this pull request Jan 25, 2018

Update history to reflect merge of #6695 [ci skip]

b2086eb

ashmaroli deleted the release-3-7-1 branch January 29, 2018 16:51

jekyll locked and limited conversation to collaborators Jul 12, 2019

jekyllbot added the frozen-due-to-age label Jul 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v3.7.1 #6695

Release v3.7.1 #6695

ashmaroli commented Jan 15, 2018 •

edited

DirtyF left a comment

DirtyF Jan 15, 2018

ashmaroli Jan 15, 2018

pathawks Jan 21, 2018

ashmaroli Jan 21, 2018

DirtyF Jan 25, 2018

DirtyF Jan 15, 2018

ashmaroli Jan 15, 2018

DirtyF Jan 15, 2018

ghost Jan 20, 2018

ashmaroli Jan 21, 2018

DirtyF Jan 15, 2018

ashmaroli Jan 15, 2018

DirtyF Jan 15, 2018

ashmaroli Jan 15, 2018

pathawks commented Jan 15, 2018

ashmaroli commented Jan 15, 2018

pathawks commented Jan 16, 2018

ashmaroli commented Jan 16, 2018 •

edited

pathawks commented Jan 17, 2018

ghost Jan 22, 2018

ghost Jan 22, 2018

ashmaroli Jan 22, 2018

ghost Jan 23, 2018

ghost Jan 22, 2018

ghost Jan 22, 2018

ghost Jan 22, 2018

DirtyF Jan 25, 2018

DirtyF Jan 25, 2018

ghost Jan 25, 2018

ashmaroli Jan 25, 2018

ghost commented Jan 25, 2018

Release v3.7.1 #6695

Release v3.7.1 #6695

Conversation

ashmaroli commented Jan 15, 2018 • edited

DirtyF left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pathawks commented Jan 15, 2018

ashmaroli commented Jan 15, 2018

pathawks commented Jan 16, 2018

ashmaroli commented Jan 16, 2018 • edited

pathawks commented Jan 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jan 25, 2018

ashmaroli commented Jan 15, 2018 •

edited

ashmaroli commented Jan 16, 2018 •

edited