inform that symlinks are not allowed in safe mode #6670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the file given to `include` / `include_relative` can't be found in safe mode it might be because it is a symlink which are not allowed in safe mode. We should make the user aware of this. This closes jekyll#6480.
ashmaroli
reviewed
Jan 14, 2018
lib/jekyll/tags/include.rb
Outdated
| @@ -192,6 +190,16 @@ def realpath_prefixed_with?(path, dir) | |||
| def read_file(file, context) | |||
| File.read(file, file_read_opts(context)) | |||
| end | |||
|
|
|||
| def could_not_locate_message(file, includes_dirs, safe) | |||
There was a problem hiding this comment.
IMO, this method should be marked as private to denote its "internal" role..
thanks @ashmaroli
parkr
approved these changes
Jan 14, 2018
|
@jekyllbot: merge +bug |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file given to
include/include_relativecan't be found in safe mode it might be because it is a symlink which are not allowed in safe mode. We should make the user aware of this.This closes #6480.
There was a note added to the symlink check two years ago which says that the symlinks could now be allowed in safe mode. Can someone confirm this as i'm not familiar with the security implications (especially for github pages)? Maybe @parkr or @envygeeks as he has written that note?
/cc @jekyll/build