Require external library only if necessary #6596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crunch09
reviewed
Dec 4, 2017
parkr
approved these changes
Jan 14, 2018
|
@jekyllbot: merge +minor |
|
@parkr this should've been marked as a |
|
@ashmaroli ruby’s |
In that case, what advantage does this change provide? |
oi.. so this was an unnecessary change..?
Depends on whether the next release is a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the Ruby interpreter does not require a library more than once, there's scope for optimization by not initiating
Jekyll::External.require_with_graceful_failunless necessary within current build session