New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mime-types. #6336
Update mime-types. #6336
Conversation
I'm not 100% sure how versioning works here, but want to make a follow up PR to https://github.com/github/pages-gem whenever this gets merged. It looks like the versions currently used are at https://pages.github.com/versions/ , and just want to be sure I make the PR to the right version if/when this gets lands in a version. |
|
@ashmaroli understood, but those rules of what a breaking change are vague. I know in nodejs/node almost any changes to existing behavior are breaking, so this would be considered breaking/major? |
But I'll defer to the word from the maintainers on this one.. |
@bmeck The GitHub team updates these mime types independently - they're not pulled in from the Jekyll gem. Which mime type are you looking to update? |
@parkr |
@jekyllbot: merge +minor |
@bmeck Ok, I'll see if we can get an update going on Pages. No promises. The best thing to do in the future is to email GitHub Support asking us to update our MIME types for GitHub Pages. They pass it along to the appropriate team. |
ran
script/vendor-mimes