Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic UTF+bom files #6322

Merged
merged 7 commits into from Oct 18, 2017
Merged

Problematic UTF+bom files #6322

merged 7 commits into from Oct 18, 2017

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Aug 18, 2017

add test files for #2853

@DirtyF DirtyF requested a review from a team August 18, 2017 17:30
@parkr
Copy link
Member

parkr commented Aug 18, 2017

Let's see if CI fails. It should.

@DirtyF
Copy link
Member Author

DirtyF commented Aug 18, 2017

Why? I didn't add a test with this files.

@Crunch09
Copy link
Member

@DirtyF 👍 I'll try to send a PR to your utf8-bom branch which adds failing tests.

@pathawks
Copy link
Member

Shouldn't this cause the fixture site to fail to build?

@DirtyF
Copy link
Member Author

DirtyF commented Oct 17, 2017

@pathawks I just merged @Crunch09 related tests, let's see if CI fails.

@pathawks
Copy link
Member

I've never been so happy to see CI fail 🤣

@parkr
Copy link
Member

parkr commented Oct 17, 2017

I have a potential fix in #6433.

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s unfortunate that it was basically a typo but hey, it’s fixed!

@pathawks
Copy link
Member

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 363bd6c into master Oct 18, 2017
@jekyllbot jekyllbot deleted the utf8-bom branch October 18, 2017 03:15
jekyllbot added a commit that referenced this pull request Oct 18, 2017
@pathawks
Copy link
Member

Shoot, I meant to change the title to something that would be more descriptive in the changelog. Oops.

pathawks pushed a commit that referenced this pull request Oct 20, 2017
pathawks added a commit that referenced this pull request Oct 20, 2017
@pathawks pathawks mentioned this pull request Oct 20, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants