Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecator.rb: fix typo for --serve command #6229

Merged
merged 5 commits into from Jul 18, 2017
Merged

deprecator.rb: fix typo for --serve command #6229

merged 5 commits into from Jul 18, 2017

Conversation

ashmaroli
Copy link
Member

Mostly a personal preference, not sure how it affects overall performance

/cc @pathawks

@ashmaroli
correct typo
78b3e6b
@ashmaroli
remove duplicate topic label
bb6b7f3 
The first warning is short enough such that it wont wrap to the next line.
Hence the subsequent message does not need a topic label.
@ashmaroli
optimize whitespace
902ed64
@ashmaroli
wrap message gracefully
d637f1a
ghost
ghost reviewed Jul 18, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, fine by me. it's basically just a matter of personal preference since i'm pretty sure we use both styles within the codebase already

@pathawks
Copy link
Member

I don't mind, but it might be worth not making changes that would muddy git blame

@ashmaroli
Copy link
Member Author

hmm, okay.. I'll use this PR to correct the typo and remove just the \n at towards the end of the file then.. k?

@ashmaroli
Copy link
Member Author

Since jekyllbot doesn't squash and merge, I'll manually rebase once the new diff is approved..

pathawks
pathawks approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after squash 👍

@DirtyF DirtyF changed the title Optimize whitespace in deprecator.rb deprecator.rb: fix typo for --serve command Jul 18, 2017
DirtyF
DirtyF approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @ashmaroli 👍

@DirtyF
Copy link
Member

DirtyF commented Jul 18, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit c0c1185 into jekyll:master Jul 18, 2017
jekyllbot added a commit that referenced this pull request Jul 18, 2017
@jekyllbot
Update history to reflect merge of #6229 [ci skip]
56546a2
@ashmaroli
Copy link
Member Author

Well I'll be a....... JekyllBot does squash and merge.. Cool!
Thanks Frank 😃

@ashmaroli ashmaroli deleted the Deprecator-whitespace branch July 18, 2017 12:39
@pathawks
Copy link
Member

I forgot about that 😜👍🏼

@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashmaroli @pathawks @DirtyF @jekyllbot