Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader#read_directories: guard against an entry not being a directory #6226

Merged
merged 2 commits into from Jul 25, 2017
Merged

Reader#read_directories: guard against an entry not being a directory #6226

merged 2 commits into from Jul 25, 2017

Conversation

parkr
Copy link
Member

@parkr parkr commented Jul 17, 2017

Fixes the following error:

Not a directory @ dir_chdir - /home/jekyll/src/_posts

/cc @jekyll/stability

@parkr parkr assigned DirtyF and pathawks and unassigned parkr and jekyllbot Jul 17, 2017
DirtyF
DirtyF approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once the formatting error is fixed:

lib/jekyll/reader.rb:41:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.

suriyaa
suriyaa approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@suriyaa suriyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@parkr
Copy link
Member Author

parkr commented Jul 25, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 188bc71 into master Jul 25, 2017
@jekyllbot jekyllbot deleted the read-directories-should-require-directory branch July 25, 2017 22:23
jekyllbot added a commit that referenced this pull request Jul 25, 2017
@jekyllbot
Update history to reflect merge of #6226 [ci skip]
7b255ba
@parkr parkr mentioned this pull request Aug 12, 2017
Closed
6 tasks
parkr added a commit that referenced this pull request Aug 12, 2017
@parkr
Backport read-directories-should-require-directory from #6226 to 3.5-…
904eeee 
…stable
@parkr parkr mentioned this pull request Aug 12, 2017
Merged
parkr added a commit that referenced this pull request Aug 12, 2017
@parkr
Merge pull request #6304 from jekyll/3.5-stable-backport-6226
867fc40 
Backport #6226 for v3.5.x: Reader#read_directories: guard against an entry not being a directory
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@suriyaa suriyaa suriyaa approved these changes

Assignees

@DirtyF DirtyF

@pathawks pathawks

Labels
fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@parkr @DirtyF @suriyaa @pathawks @jekyllbot