Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump supported Ruby version to >= 2.1.0 #6220

Merged
merged 1 commit into from Jul 25, 2017
Merged

Bump supported Ruby version to >= 2.1.0 #6220

merged 1 commit into from Jul 25, 2017

Conversation

ashmaroli
Copy link
Member

I realized from #6216 that our runtime_dependency Liquid 4.0 has already dropped support for Ruby Versions older than 2.1.0. So there's no point in not following suit ourselves.

parkr
parkr requested changes Jul 13, 2017
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot do this until Jekyll 4.0. We can only implicitly drop support by dropping Travis CI targets. Many users still use Ruby 2.0 and if they want to, we can't stop them in Jekyll 3.x.

@parkr
Copy link
Member

parkr commented Jul 13, 2017

This is a major breaking change and will have to wait for v4.0 which we have no plans for at the moment. Thanks!

@parkr parkr closed this Jul 13, 2017
@parkr
Copy link
Member

parkr commented Jul 13, 2017

Ah, I see, Liquid has already done this.

@parkr parkr reopened this Jul 13, 2017
@parkr parkr added this to the 3.6 milestone Jul 17, 2017
@parkr
Copy link
Member

parkr commented Jul 25, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 96724af into jekyll:master Jul 25, 2017
jekyllbot added a commit that referenced this pull request Jul 25, 2017
@jekyllbot
Update history to reflect merge of #6220 [ci skip]
8a017b5
@ashmaroli ashmaroli deleted the bump-min-ruby-version branch July 31, 2017 04:08
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@parkr parkr parkr approved these changes

@Crunch09 Crunch09 Crunch09 approved these changes

Assignees

@parkr parkr

Labels
dependency frozen-due-to-age
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ashmaroli @parkr @DirtyF @Crunch09 @jekyllbot