New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access custom config array throughout session #6200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig the idea.
Three things: (1) when config is empty/has an empty string like above, as checked in the line directly after the one you change, let's fill that in with whatever file we read by default; (2) let's add a test; (3) let's not expose this in liquid yet, so create a no-op method in SiteDrop called config.
(1) Isn't that how it is already? |
Hi, Any other changes to be made? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me
👍 Thanks Olivia |
👏 @jekyllbot: merge +minor |
Resolves #6180
Instead of having the array of custom configs removed, let it be available throughout current session.
Specific Use Case:
Allow Jekyll Admin to determine which config file to re-read if not the default
_config.yml
or_config.yaml
/cc @jekyll/ecosystem @parkr