Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access custom config array throughout session #6200

Merged
merged 3 commits into from Aug 7, 2017

Conversation

ashmaroli
Copy link
Member

Resolves #6180
Instead of having the array of custom configs removed, let it be available throughout current session.

Specific Use Case:

Allow Jekyll Admin to determine which config file to re-read if not the default _config.yml or _config.yaml

/cc @jekyll/ecosystem @parkr

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig the idea.

Three things: (1) when config is empty/has an empty string like above, as checked in the line directly after the one you change, let's fill that in with whatever file we read by default; (2) let's add a test; (3) let's not expose this in liquid yet, so create a no-op method in SiteDrop called config.

@ashmaroli
Copy link
Member Author

ashmaroli commented Jul 3, 2017

Three things: (1) when config is empty/has an empty string like above, as checked in the line directly after the one you change, let's fill that in with whatever file we read by default; (2) let's add a test; (3) let's not expose this in liquid yet, so create a no-op method in SiteDrop called config.

(1) Isn't that how it is already? If config_files is an empty array, proceed to look for default config file(s)
(2) Fixing failing tests do produce enough results asserting the changed behavior, no clear on what else needs to be tested..
(3) Implemented with an empty #config

@parkr

@ashmaroli
Copy link
Member Author

Hi, Any other changes to be made?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@ashmaroli
Copy link
Member Author

👍 Thanks Olivia

@parkr
Copy link
Member

parkr commented Aug 7, 2017

👏

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit c8eee7f into jekyll:master Aug 7, 2017
jekyllbot added a commit that referenced this pull request Aug 7, 2017
@ashmaroli ashmaroli deleted the access-custom-configs branch August 7, 2017 16:15
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Custom config file array
4 participants