New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore final newline in folded YAML string #6054
Conversation
before: {{ site.description }} => "Write an awesome description for your new site here. You can edit this line in _config.yml. It will appear in your document head meta (for Google search results) and in your feed.xml site description./n" after: {{ site.description }} => "Write an awesome description for your new site here. You can edit this line in _config.yml. It will appear in your document head meta (for Google search results) and in your feed.xml site description."
/cc @jekyll/ecosystem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Should we also test that the new site's site.config["description"]
doesn't have a trailing newline?
I think its implied.. |
That's the point... I don't want it to be implicit, I think if we're making this change we should explicitly test it. |
@ashmaroli do you intend to test for a trailing newline here? |
Sorry, I forgot all about this. Thanks for reminding.. Will push a commit shortly. |
This comment has been minimized.
This comment has been minimized.
@jekyllbot: merge +minor |
before:
{{ site.description }}
=>after:
{{ site.description }}
=>