Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore final newline in folded YAML string #6054

Merged
merged 3 commits into from Jul 18, 2017

Conversation

ashmaroli
Copy link
Member

before: {{ site.description }} =>

"Write an awesome description for your new site here. You can edit this line in _config.yml. It
will appear in your document head meta (for Google search results) and in your feed.xml site
description./n"

after: {{ site.description }} =>

"Write an awesome description for your new site here. You can edit this line in _config.yml. It
will appear in your document head meta (for Google search results) and in your feed.xml site
description."

  before: {{ site.description }} =>
	  "Write an awesome description for your new site here. You can
	  edit this line in _config.yml. It will appear in your document
	  head meta (for Google search results) and in your feed.xml site
	  description./n"

   after: {{ site.description }} =>
	  "Write an awesome description for your new site here. You can
	  edit this line in _config.yml. It will appear in your document
	  head meta (for Google search results) and in your feed.xml site
	  description."
@ashmaroli
Copy link
Member Author

/cc @jekyll/ecosystem

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Should we also test that the new site's site.config["description"] doesn't have a trailing newline?

@ashmaroli
Copy link
Member Author

Should we also test that the new site's site.config["description"] doesn't have a trailing newline?

I think its implied..

@parkr
Copy link
Member

parkr commented May 10, 2017

I think its implied..

That's the point... I don't want it to be implicit, I think if we're making this change we should explicitly test it.

@DirtyF
Copy link
Member

DirtyF commented Jun 21, 2017

@ashmaroli do you intend to test for a trailing newline here?

@ashmaroli
Copy link
Member Author

do you intend to test for a trailing newline here?

Sorry, I forgot all about this. Thanks for reminding.. Will push a commit shortly.

@ashmaroli

This comment has been minimized.

@DirtyF
Copy link
Member

DirtyF commented Jul 18, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 026f828 into jekyll:master Jul 18, 2017
jekyllbot added a commit that referenced this pull request Jul 18, 2017
@ashmaroli ashmaroli deleted the yaml-fold-newline branch July 18, 2017 07:31
DirtyF added a commit that referenced this pull request Sep 30, 2018
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants