kramdown GFM is not enable?

[garin]

I'm setting kramdown's GFM support

_config.yml

markdown: kramdown
kramdown:
  input: GFM

but unenable GFM format

pry-byebug

jekyll/lib/jekyll/converters/markdown/kramdown_parser.rb

Line 41 in 27ed815

Kramdown::Document.new(content, @config).to_html

    42: def convert(content)
    43:    binding.pry
 => 44:   Kramdown::Document.new(content, @config).to_html
    45: end

[1] pry(#<Jekyll::Converters::Markdown::KramdownParser>)> p @config
=> {"auto_ids"=>true,
 "toc_levels"=>"1..6",
 "entity_output"=>"as_char",
 "smart_quotes"=>"lsquo,rsquo,ldquo,rdquo",
 "input"=>"GFM",                             # GFM enable ? 
 "hard_wrap"=>false,
 "footnote_nr"=>1,
 "syntax_highlighter"=>"rouge",
 "syntax_highlighter_opts"=>{},
 "coderay"=>{}}

with all @config optoins
> Kramdown::Document.new("aaa\nbbb", @config).to_html
=> "<p>aaa\n" + "bbb</p>\n"           # not with linebreak

input GMF option only 
> Kramdown::Document.new("aaa\nbbb", input: 'GFM').to_html
=> "<p>aaa<br />\n" + "bbb</p>\n"     # with linebreak. (I want this behavior)

environment

• debian-9
• ruby-2.4.1
• jekylly-3.4.3
• kramdown-1.13.2

[DirtyF]

/cc @jekyll/build

[parkr]

Hm, this might be a question for @gettalong. It looks like we're using kramdown properly, based on your pry output.

[gettalong]

@parkr @garin Looks like the config uses the string key "input" instead of the symbol :input.

[parkr]

That would do it! Thank you, @gettalong.

I believe our code turns these keys into symbols... If not, we should add a test & symbolize the keys!

[jekyllbot]

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the 3.3-stable or master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

[iceman201]

I have same issue with my jekyll page.
any fix update?

[parkr]

@gettalong Our code currently uses default_proc to give access for symbolized keys. It looks like Options.merge doesn't handle that.

[parkr]

Patch ready for review: #6247