Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting author.url #453

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Allow setting author.url #453

merged 3 commits into from
Oct 8, 2021

Conversation

imustafin
Copy link
Contributor

Starting from August 6, 2021 Google recommends to set the author.url property. This property helps Google to disambiguate the correct author of the article.

This PR adds the ability to specify the author url together with the other author properties.

@imustafin
Copy link
Contributor Author

@ashmaroli hi! I don't know if you are the correct person to ping, so sorry for disturbing.

Is there anything needed from my side to move forward with this PR?

@ashmaroli
Copy link
Member

@imustafin The proposed diff looks good to me.
Just one minor thing. Could you add a test to prove that author["url"] is null when not provided..?
(Appending to an existing test for author will suffice.)

@imustafin
Copy link
Contributor Author

@ashmaroli did you mean something like this?

@ashmaroli
Copy link
Member

did you mean something like this?

Yes. That'll do.
Thanks.

@ashmaroli ashmaroli changed the title Allow to set author url Allow setting author.url Oct 8, 2021
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ashmaroli
Copy link
Member

Thank you @imustafin
@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 8b5d290 into jekyll:master Oct 8, 2021
jekyllbot added a commit that referenced this pull request Oct 8, 2021
@jekyll jekyll locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants